refactor(general): increase number of retained maintenance run info #4846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4846 +/- ##
==========================================
+ Coverage 75.86% 76.42% +0.56%
==========================================
Files 470 533 +63
Lines 37301 40581 +3280
==========================================
+ Hits 28299 31016 +2717
- Misses 7071 7525 +454
- Partials 1931 2040 +109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR increases the retention limit for maintenance run information from 5 to 50 entries per run type to preserve more historical data about maintenance task executions.
- Increased the
maxRetainedRunInfoPerRunTypeconstant from 5 to 50 - Updated corresponding test assertion to accommodate the higher retention limit
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| repo/maintenance/maintenance_schedule.go | Increases the maximum retained run info entries per run type from 5 to 50 |
| tests/end_to_end_test/server_start_test.go | Updates test assertion upper bound to match the new retention limit |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @jkowalski