Skip to content

Conversation

@julio-lopez
Copy link
Collaborator

No description provided.

@julio-lopez julio-lopez requested a review from Copilot September 24, 2025 01:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves test reliability by ensuring background worker goroutines are properly stopped when a test fails or completes. The change replaces a channel-based shutdown mechanism with an atomic boolean flag and adds a test cleanup function to guarantee worker termination.

  • Replaces channel-based worker shutdown with atomic boolean for cleaner control flow
  • Adds t.Cleanup() to ensure workers stop even if test fails early
  • Simplifies worker loop structure by removing select statement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.42%. Comparing base (cb455c6) to head (427526d).
⚠️ Report is 665 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4841      +/-   ##
==========================================
+ Coverage   75.86%   76.42%   +0.56%     
==========================================
  Files         470      533      +63     
  Lines       37301    40582    +3281     
==========================================
+ Hits        28299    31016    +2717     
- Misses       7071     7524     +453     
- Partials     1931     2042     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-lopez julio-lopez marked this pull request as ready for review September 24, 2025 03:04
@julio-lopez julio-lopez merged commit a96be32 into kopia:master Sep 24, 2025
27 checks passed
@julio-lopez julio-lopez deleted the harden-content-test branch September 24, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant