feat(general): perform content-to-pack consistency checks in maintenance #4832
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds content-to-pack consistency checks during maintenance operations to verify that all referenced packs are present in storage. The feature is controlled by an environment variable and runs probabilistically.
- Introduces a new content index verification function that checks consistency between content index entries and pack files
- Replaces
ReportRuncalls withreportRunAndMaybeCheckContentIndexacross maintenance tasks to enable optional consistency checking - Implements probabilistic execution based on the
KOPIA_MAINTENANCE_CONTENT_VERIFY_PERCENTAGEenvironment variable
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| content_index_to_pack_check.go | New file implementing content-to-pack consistency checking logic |
| maintenance_run.go | Updates maintenance task functions to use the new consistency checking wrapper |
| index_compaction.go | Updates index compaction task to use the new consistency checking wrapper |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4832 +/- ##
==========================================
+ Coverage 75.86% 76.43% +0.56%
==========================================
Files 470 533 +63
Lines 37301 40591 +3290
==========================================
+ Hits 28299 31025 +2726
- Misses 7071 7526 +455
- Partials 1931 2040 +109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
redgoat650
left a comment
There was a problem hiding this comment.
Looks good, just one question
0fac4ca to
bcb6070
Compare
No description provided.