refactor(general): cleanup VSS trailer handling #4776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use `isWindows` const in isWindowsVSSVolume function
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4776 +/- ##
==========================================
+ Coverage 75.86% 76.42% +0.56%
==========================================
Files 470 530 +60
Lines 37301 40443 +3142
==========================================
+ Hits 28299 30910 +2611
- Misses 7071 7494 +423
- Partials 1931 2039 +108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors VSS (Volume Shadow Service) trailer handling on Windows by consolidating the logic and improving code organization. It follows up on PR #3891 to clean up the implementation.
- Consolidates Windows-specific logic into platform-specific files
- Replaces the
isWindowsVSSVolume()method with a more focusedtrailingSeparator()function - Introduces a consistent
separatorStrconstant andisWindowsvariable across the codebase
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| fs/localfs/local_fs_windows.go | Adds Windows-specific isWindows variable and trailingSeparator() function |
| fs/localfs/local_fs_nonwindows.go | Adds non-Windows constants and stub implementation of trailingSeparator() |
| fs/localfs/local_fs_os.go | Refactors to use new trailingSeparator() function and separatorStr constant |
| fs/localfs/local_fs_test.go | Updates test code to use new isWindows variable |
| fs/localfs/local_fs.go | Removes the old isWindowsVSSVolume() method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Ref:
Additional cleanups:
fs/localfs.isWindowsa constlocal_fs_windows.go//nolint:reviveannotations