fix(general): add {peta,exa}byte prefixes #4707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
julio-lopez
commented
Jul 2, 2025
- extend unit test cases for additional units
- refactor tests
There was a problem hiding this comment.
Pull Request Overview
This PR extends byte unit support to include petabyte (P) and exabyte (E) prefixes and refactors the existing unit tests to use testify/require with table-driven t.Run subtests.
- Added “P” and “E” to both
base10UnitPrefixesandbase2UnitPrefixes - Changed test value types from
int64touint64, expanded test cases to cover PB and EB - Switched tests to
require.Equaland splitTestBytesStringinto two env-based subtests witht.Run
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/units/units.go | Extended base10UnitPrefixes and base2UnitPrefixes to include “P” and “E” |
| internal/units/units_test.go | Refactored unit tests: use fmt + require, convert to uint64, add subtests, cover PB/EB |
Comments suppressed due to low confidence (3)
internal/units/units_test.go:103
- [nitpick] Test function names are mixed between camelCase and snake_case. Consider renaming to
TestBytesStringBase2EnvFalsefor consistency with other test names.
func TestBytesString_base2EnvFalse(t *testing.T) {
internal/units/units_test.go:114
- [nitpick] For consistency with existing test names, consider renaming to
TestBytesStringBase2EnvTrueinstead of using an underscore.
func TestBytesString_base2EnvTrue(t *testing.T) {
internal/units/units_test.go:66
- This entry duplicates the earlier
{1000000000000, "0.9 TiB"}case. Please remove the redundant test row to avoid confusion.
{1000000000000, "0.9 TiB"},
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4707 +/- ##
==========================================
+ Coverage 75.86% 76.41% +0.54%
==========================================
Files 470 530 +60
Lines 37301 40373 +3072
==========================================
+ Hits 28299 30850 +2551
- Misses 7071 7488 +417
- Partials 1931 2035 +104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.