chore(general): minor cleanups #4704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR includes cleanup and refactoring across multiple packages, improving naming consistency and test assertions while removing obsolete lint configurations.
- Use
slices.CloneinSortByTimefor clearer slice copying. - Rename the exported function
DropDeletedContentsto unexporteddropDeletedContentsand update references. - Refactor tests to use
requireassertions and remove an outdated.gometalinter.json.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| snapshot/manifest.go | Switched to slices.Clone instead of manual slice append. |
| repo/maintenance/maintenance_run.go | Updated call from DropDeletedContents to dropDeletedContents. |
| repo/maintenance/drop_deleted_contents.go | Renamed DropDeletedContents to dropDeletedContents. |
| repo/content/committed_content_index.go | Renamed fetchOne to fetchIndexBlob for clarity. |
| internal/repotesting/repotesting_test.go | Replaced manual error checks with require assertions. |
| cli/command_snapshot_verify.go | Removed //nolint:wrapcheck directive. |
| .gometalinter.json | Deleted obsolete linter configuration. |
Comments suppressed due to low confidence (4)
repo/maintenance/drop_deleted_contents.go:12
- Making
DropDeletedContentsunexported is a breaking change in the repo API; consider providing a deprecated alias or ensuring no external callers rely on this function.
func dropDeletedContents(ctx context.Context, rep repo.DirectRepositoryWriter, dropDeletedBefore time.Time, safety SafetyParameters) error {
internal/repotesting/repotesting_test.go:77
- [nitpick] The error message 'failed to get create snapshot' is grammatically incorrect; consider using 'failed to create snapshot' for clarity.
require.NoError(t, err, "failed to get create snapshot")
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4704 +/- ##
==========================================
+ Coverage 75.86% 76.38% +0.51%
==========================================
Files 470 530 +60
Lines 37301 40371 +3070
==========================================
+ Hits 28299 30838 +2539
- Misses 7071 7494 +423
- Partials 1931 2039 +108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
cc: @andrason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slices.Clone.gometalinter.jsonmaintenance.dropDeletedContentsfetchIndexBlobrequireinTestTimeFuncWiring