feat(cli): human-readable sizes for kopia ls #4696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support for a -h/--human-readable flag to the kopia ls command so sizes can be displayed in a human-readable format.
- Introduces a
humanSizesfield and--human-readableflag with short-h - Updates
printDirectoryEntryto format sizes viamaybeHumanReadableBytes
Comments suppressed due to low confidence (3)
cli/command_ls.go:18
- [nitpick] Consider renaming the
humanSizesfield tohumanReadable(or similar) to more clearly match the--human-readableflag and improve consistency.
humanSizes bool
cli/command_ls.go:118
- Add unit tests for the
--human-readableflag to ensuremaybeHumanReadableBytesformats sizes correctly in both human-readable and raw modes.
maybeHumanReadableBytes(c.humanSizes, e.Size()),
cli/command_ls.go:31
- Verify that the shortcut
-hdoes not conflict with the default help flag; if it does, consider using a different shortcut or omitting the short form.
cmd.Flag("human-readable", "Show human-readable sizes").Short('h').BoolVar(&c.humanSizes)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4696 +/- ##
==========================================
+ Coverage 75.86% 76.38% +0.52%
==========================================
Files 470 530 +60
Lines 37301 40372 +3071
==========================================
+ Hits 28299 30840 +2541
- Misses 7071 7494 +423
- Partials 1931 2038 +107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julio-lopez
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
-h/--human-readableoption tokopia lsto print sizes in human-readable format.kopia ls#4501