Skip to content

Conversation

@NathanBaulch
Copy link
Contributor

Great project! Just thought I'd contribute some typo fixes, nothing controversial hopefully.

FWIW, the most common typos are:

  • snaphot
  • bechmark
  • oject
  • compresion
  • shapshot
  • paramters
  • parallellism
  • defaul
  • creater
  • unti
  • timespect
  • specifc
  • representible
  • repositor
  • paramers
  • initia
  • arbitrality

@julio-lopez julio-lopez requested a review from Copilot June 10, 2025 23:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a number of typos in comments, variable names, and function identifiers across the codebase.

  • Corrects several spelling errors in documentation and error messages
  • Renames variables and test function identifiers for clarity and consistency

Reviewed Changes

Copilot reviewed 75 out of 75 changed files in this pull request and generated 20 comments.

Show a summary per file
File Description
internal/faketime/faketime.go Fixes a typo in a comment describing time math
internal/epoch/epoch_manager.go Renames a variable to correct a typo
internal/diff/diff_test.go Fixes typos in test comments regarding snapshot order
internal/diff/diff.go Corrects a typo in a comment regarding stat updates
internal/cacheprot/storage_protection_test.go Fixes a typo in a test function name
internal/blobtesting/concurrent.go Corrects a typo in a comment describing shared blobs
cli/command_snapshot_list.go Fixes typos in a boolean flag variable and its usage
cli/command_server_tls.go Corrects a typo in a TLS comment
cli/command_restore_test.go Fixes a typo in a parameter name in a test helper
cli/command_repository_upgrade.go Fixes typos in comments regarding index comparisons
cli/command_repository_set_client.go Corrects a typo in a log message about indices
cli/command_maintenance_set_test.go Fixes several typos in error messages for object locks tests
cli/command_benchmark_test.go Renames a test function to correct a typo
cli/command_benchmark_compression.go Corrects a series of typos in compression benchmarks types and function signatures
app/sign.mjs Fixes a typo in a console log message
.golangci.yml Corrects a typo in a linter recommendation comment
.github/workflows/make.yml Corrects a typo in a comment regarding notarization
Comments suppressed due to low confidence (8)

cli/command_benchmark_test.go:40

  • Rename the test function from 'TestCommandBenchmarkSpliter' to 'TestCommandBenchmarkSplitter' for clarity.
func TestCommandBenchmarkSplitter(t *testing.T) {

cli/command_benchmark_compression.go:83

  • Correct the struct name from 'compressionBechmarkResult' to 'compressionBenchmarkResult'.
type compressionBenchmarkResult struct {

cli/command_benchmark_compression.go:169

  • Update the variable type from 'compressionBechmarkResult' to 'compressionBenchmarkResult'.
var results []compressionBenchmarkResult

cli/command_benchmark_compression.go:227

  • Fix the type name in the append call from 'compressionBechmarkResult' to 'compressionBenchmarkResult'.
results = append(results, compressionBenchmarkResult{

cli/command_benchmark_compression.go:244

  • Update the variable type from 'compressionBechmarkResult' to 'compressionBenchmarkResult' for decompression results.
var results []compressionBenchmarkResult

cli/command_benchmark_compression.go:297

  • Correct the type name in the append call from 'compressionBechmarkResult' to 'compressionBenchmarkResult'.
results = append(results, compressionBenchmarkResult{

cli/command_benchmark_compression.go:312

  • Update the function signature to use 'compressionBenchmarkResult' instead of 'compressionBechmarkResult'.
func (c *commandBenchmarkCompression) sortResults(results []compressionBenchmarkResult) {

cli/command_benchmark_compression.go:329

  • Update the function signature to use 'compressionBenchmarkResult' instead of 'compressionBechmarkResult'.
func (c *commandBenchmarkCompression) printResults(results []compressionBenchmarkResult) {

// only a single snapshot in the repo;
// - Subsequently add more snapshots and GetPreceedingSnapshot theimmediately
// - Subsequently add more snapshots and GetPrecedingSnapshot the immediately
// preceding with no error.
Copy link

Copilot AI Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the typo 'theimmediately' to 'the immediately' in the comment.

Suggested change
// preceding with no error.
// preceding snapshot with no error.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.39%. Comparing base (cb455c6) to head (a0789f3).
Report is 570 commits behind head on master.

Files with missing lines Patch % Lines
internal/serverapi/client_wrappers.go 33.33% 0 Missing and 2 partials ⚠️
cli/command_repository_set_client.go 0.00% 1 Missing ⚠️
cli/command_snapshot_list.go 50.00% 0 Missing and 1 partial ⚠️
internal/server/api_snapshots.go 0.00% 1 Missing ⚠️
internal/user/hash_password.go 0.00% 1 Missing ⚠️
repo/blob/sftp/sftp_storage.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4659      +/-   ##
==========================================
+ Coverage   75.86%   76.39%   +0.52%     
==========================================
  Files         470      529      +59     
  Lines       37301    40161    +2860     
==========================================
+ Hits        28299    30680    +2381     
- Misses       7071     7462     +391     
- Partials     1931     2019      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-lopez julio-lopez merged commit 19d9261 into kopia:master Jun 11, 2025
26 of 27 checks passed
@NathanBaulch NathanBaulch deleted the typos branch June 11, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants