refactor(general): misc cleanups #4652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR performs miscellaneous cleanups across test code, simplifying temporary directory creation, unifying skip helper names, and modernizing assertion patterns.
- Replace manual
os.MkdirTempsetup witht.TempDirand consolidate error checks usingrequire - Rename and consolidate skip helpers from
TestSkip*toSkipTest*and update their usage - Convert Windows path literals to raw string syntax and streamline CLI test logging
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/tools/kopiarunner/kopia_snapshotter_exe_test.go | Switch to t.TempDir, use require helpers, and consolidate empty-slice check |
| tests/testenv/cli_test_env.go | Cache getLogOutputPrefix result, simplify stdout/stderr logging conditions |
| tests/end_to_end_test/restore_test.go | Rename TestSkipUnlessLinux to SkipTestUnlessLinux |
| tests/end_to_end_test/norace_test.go | Use t.TempDir instead of testutil.TempDirectory, remove unused import |
| snapshot/upload/upload_test.go | Add assertion messages, rename skip helper to SkipTestOnCIUnlessLinuxAMD64 |
| repo/blob/sftp/sftp_storage_test.go | Rename skip helper to SkipTestOnCIUnlessLinuxAMD64 |
| repo/blob/s3/s3_storage_test.go | Rename skip helper to SkipTestOnCIUnlessLinuxAMD64 |
| internal/testutil/testutil.go | Remove deprecated TestSkip* functions, add SkipTest* replacements |
| internal/testutil/dockertestutil.go | Replace TestSkipUnlessCI with explicit tb.Skipf/tb.Fatalf logic |
| fs/localfs/local_fs_test.go | Convert Windows path literals to raw string backticks for clarity |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4652 +/- ##
==========================================
+ Coverage 75.86% 76.39% +0.53%
==========================================
Files 470 529 +59
Lines 37301 40160 +2859
==========================================
+ Hits 28299 30682 +2383
- Misses 7071 7460 +389
- Partials 1931 2018 +87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.