refactor(general): misc cleanups #4615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request performs general code cleanups and refactoring across multiple modules. Key changes include:
- Renaming functions from exported to unexported (e.g. Compressed → compressed, IndirectObjectID → indirectObjectID)
- Replacing panic calls with impossible.PanicOnError across several modules and using modern idioms such as maps.Clone for label copying
- Adding checklock annotations and renaming local variables for improved clarity (e.g. packNumberByPrefix → packCountByPrefix)
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| repo/object/objectid.go | Function renames and comment updates for unexported functions |
| repo/object/object_writer.go | Updates to locking annotations and renaming flushBuffer to flushBufferLocked |
| repo/manifest/manifest_manager.go | Replacing custom label copy with maps.Clone |
| repo/manifest/committed_manifest_manager.go | Replacing panic calls with impossible.PanicOnError |
| repo/maintenance/content_rewrite.go | Renaming variables for clarity |
| repo/compression/compressor.go | Replacing panic calls with impossible.PanicOnError |
| internal/server/source_manager.go | Change made to control flow in snapshot handling |
| internal/crypto/key_derivation.go | Replacing panic calls with impossible.PanicOnError |
| cli/json_output.go | Replacing panic calls with impossible.PanicOnError |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4615 +/- ##
==========================================
+ Coverage 75.86% 76.41% +0.55%
==========================================
Files 470 529 +59
Lines 37301 40162 +2861
==========================================
+ Hits 28299 30691 +2392
- Misses 7071 7456 +385
- Partials 1931 2015 +84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.