fix(snapshots): fixed snapshotting of \\server\share #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4603 +/- ##
==========================================
+ Coverage 75.86% 76.39% +0.52%
==========================================
Files 470 529 +59
Lines 37301 40128 +2827
==========================================
+ Hits 28299 30656 +2357
- Misses 7071 7451 +380
- Partials 1931 2021 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julio-lopez
approved these changes
May 25, 2025
julio-lopez
reviewed
May 25, 2025
Comment on lines
+290
to
+300
| cases["c:/"] = pair{"c:/", ""} | ||
| cases["c:\\"] = pair{"c:\\", ""} | ||
| cases["c:/temp"] = pair{"c:/", "temp"} | ||
| cases["c:\\temp"] = pair{"c:\\", "temp"} | ||
| cases["c:/temp/orary"] = pair{"c:/temp/", "orary"} | ||
| cases["c:\\temp\\orary"] = pair{"c:\\temp\\", "orary"} | ||
| cases["c:/temp\\orary"] = pair{"c:/temp\\", "orary"} | ||
| cases["c:\\temp/orary"] = pair{"c:\\temp/", "orary"} | ||
| cases["\\\\server\\path"] = pair{"\\\\server\\", "path"} | ||
| cases["\\\\server\\path\\"] = pair{"\\\\server\\path\\", ""} | ||
| cases["\\\\server\\path\\subdir"] = pair{"\\\\server\\path\\", "subdir"} |
Collaborator
There was a problem hiding this comment.
nit: does it make sense to use raw strings here for readability?
Suggested change
| cases["c:/"] = pair{"c:/", ""} | |
| cases["c:\\"] = pair{"c:\\", ""} | |
| cases["c:/temp"] = pair{"c:/", "temp"} | |
| cases["c:\\temp"] = pair{"c:\\", "temp"} | |
| cases["c:/temp/orary"] = pair{"c:/temp/", "orary"} | |
| cases["c:\\temp\\orary"] = pair{"c:\\temp\\", "orary"} | |
| cases["c:/temp\\orary"] = pair{"c:/temp\\", "orary"} | |
| cases["c:\\temp/orary"] = pair{"c:\\temp/", "orary"} | |
| cases["\\\\server\\path"] = pair{"\\\\server\\", "path"} | |
| cases["\\\\server\\path\\"] = pair{"\\\\server\\path\\", ""} | |
| cases["\\\\server\\path\\subdir"] = pair{"\\\\server\\path\\", "subdir"} | |
| cases[`c:/`] = pair{`c:/`, ``} | |
| cases[`c:\`] = pair{`c:\`, ``} | |
| cases[`c:/temp`] = pair{`c:/`, `temp`} | |
| cases[`c:\temp`] = pair{`c:\`, `temp`} | |
| cases[`c:/temp/orary`] = pair{`c:/temp/`, `orary`} | |
| cases[`c:\temp\orary`] = pair{`c:\temp\`, `orary`} | |
| cases[`c:/temp\orary`] = pair{`c:/temp\`, `orary`} | |
| cases[`c:\temp/orary`] = pair{`c:\temp/`, `orary`} | |
| cases[`\\server\path`] = pair{`\\server\`, `path`} | |
| cases[`\\server\path\`] = pair{`\\server\path\`, ``} | |
| cases[`\\server\path\subdir`] = pair{`\\server\path\`, `subdir`} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.