Skip to content

fix(server): fixed server-based notifications #4598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkowalski merged 2 commits into from
May 24, 2025
Merged

fix(server): fixed server-based notifications #4598

jkowalski merged 2 commits into from
May 24, 2025

Conversation

@jkowalski
Copy link
Contributor

@jkowalski jkowalski commented May 24, 2025 •
edited
Loading

Used TypedEventArgs instead of any to ensure all notification data carries type information, allowing the server to property deserialize it.

Replaces #4403

@jkowalski
fix(server): fixed server-based notifications
8823228 
Used TypedEventArgs instead of `any` to ensure all notification data
carries type information, allowing the server to property deserialize it.
@jkowalski jkowalski force-pushed the server-notification-type branch from b2d58b7 to 8823228 Compare May 24, 2025 14:29
@jkowalski jkowalski mentioned this pull request May 24, 2025
Closed
@codecov
Copy link

codecov bot commented May 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.35%. Comparing base (cb455c6) to head (3282485).
Report is 527 commits behind head on master.

Files with missing lines Patch % Lines
notification/notifydata/typed_event_args.go 68.75% 4 Missing and 1 partial ⚠️
internal/server/grpc_session.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4598      +/-   ##
==========================================
+ Coverage   75.86%   76.35%   +0.49%     
==========================================
  Files         470      529      +59     
  Lines       37301    40118    +2817     
==========================================
+ Hits        28299    30633    +2334     
- Misses       7071     7460     +389     
- Partials     1931     2025      +94

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkowalski jkowalski merged commit fec575b into kopia:master May 24, 2025
27 of 28 checks passed
This was referenced May 26, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jkowalski