test(cli): minor cleanups in diff tests #4594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helper to generate (direct) object ids.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces minor cleanups to diff tests by replacing the direct use of index-generated IDs with new helper functions (oidForString and oidForContent) to generate direct object IDs.
- Replaced calls to index.IDFromHash with oidForString for clearer, centralized ID generation.
- Updated import paths and adjusted test signatures to pass *testing.T where necessary.
Comments suppressed due to low confidence (2)
internal/diff/diff_test.go:468
- [nitpick] Consider renaming 'LatestSnapshotManifest' to 'latestSnapshotManifest' to follow conventional Go naming practices for local variables.
LatestSnapshotManifest := &snapshot.Manifest{
internal/diff/diff_test.go:113
- The prefix for generating oid2 has been changed from 'i' to 'p', which may lead to identical object IDs for different directories. Confirm that this change is intentional and does not cause unintended collisions in object identifiers.
oid2 := oidForString(t, "p", "dfjlgn")
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4594 +/- ##
==========================================
+ Coverage 75.86% 76.38% +0.51%
==========================================
Files 470 527 +57
Lines 37301 40091 +2790
==========================================
+ Hits 28299 30623 +2324
- Misses 7071 7449 +378
- Partials 1931 2019 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julio-lopez
commented
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper to generate (direct) object ids.