chore(ci): enforce consistent formatting of KopiaUI code #4586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces consistent code formatting across the KopiaUI codebase using Double quotes, trailing commas, and multiline argument lists, and enforces these rules via Prettier in CI.
- Normalized string quotes to double quotes and added semicolons
- Reformatted arrays/objects and argument lists to multiline with trailing commas
- Added Prettier as a dev dependency, npm scripts, Makefile targets, and CI workflow steps
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/tests/main.spec.js | Updated quotes/semicolons, multiline path joins, and trailing commas |
| app/sign.mjs | Normalized quotes, semicolons, and multiline arrays |
| app/public/utils.js | Converted function to IIFE, quotes, semicolons, and multiline maps |
| app/public/server.js | Quotes, semicolons, and multiline argument lists |
| app/public/preload.js | Quotes, semicolons, and object literal formatting |
| app/public/notifications.js | Quotes, semicolons, and multiline fs calls |
| app/public/index.html | Lowercased doctype |
| app/public/config.js | Quotes, semicolons, and multiline path joins |
| app/public/auto-launch.js | Quotes, semicolons, and promise chains formatted |
| app/package.json | Added Prettier dependency and scripts |
| app/notarize.mjs | Quotes, semicolons, and multiline logging calls |
| Makefile | Added check-prettier and prettier targets |
| .github/workflows/lint.yml | Added Prettier check step |
Files not reviewed (1)
- app/package-lock.json: Language not supported
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4586 +/- ##
==========================================
+ Coverage 75.86% 76.39% +0.53%
==========================================
Files 470 527 +57
Lines 37301 40091 +2790
==========================================
+ Hits 28299 30629 +2330
- Misses 7071 7443 +372
- Partials 1931 2019 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julio-lopez
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.