fix(providers): human-friendly persistence of role duration #4546
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4546 +/- ##
==========================================
+ Coverage 75.86% 76.34% +0.47%
==========================================
Files 470 527 +57
Lines 37301 40047 +2746
==========================================
+ Hits 28299 30573 +2274
- Misses 7071 7455 +384
- Partials 1931 2019 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| import ( | ||
| "time" | ||
|
|
||
| "github.com/kopia/kopia/internal/jsonencoding" |
There was a problem hiding this comment.
will this cause problems for callers? The type is technically in a package under internal, so I'm not sure if callers will be able to name the type to cast to it when making the config. In other words, I don't know if the below will compile
opts := Options{
// I don't think external callers can import jsonencoding
RoleDuration: jsonencoding.Duration(5 * time.Second),
}There was a problem hiding this comment.
@ashmrtn I see what you mean.
It's not an issue if the caller is inside kopia, however it is a type in the "exposed" interface for the blob/s3 package.
The package could be moved to repo/jsonencoding, does that work?
There was a problem hiding this comment.
yea, that would work. Do you want me to spin up a PR moving the package? We could merge it after this one if that makes it easier
| import ( | ||
| "time" | ||
|
|
||
| "github.com/kopia/kopia/internal/jsonencoding" |
There was a problem hiding this comment.
yea, that would work. Do you want me to spin up a PR moving the package? We could merge it after this one if that makes it easier
No description provided.