refactor(cli): cleanup cli.repositoryAccessMode
#4541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is always `true`.
Rename `repositoryAccessMode.disableMaintenance` to `allowMaintenance`. This explicitly conveys when maintenance is allowed to run. Related to accessing a repository in 'read-only' mode.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4541 +/- ##
==========================================
+ Coverage 75.86% 76.37% +0.50%
==========================================
Files 470 527 +57
Lines 37301 40049 +2748
==========================================
+ Hits 28299 30588 +2289
- Misses 7071 7444 +373
- Partials 1931 2017 +86 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
repositoryAccessModecli.repositoryAccessMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
repositoryAccessMode.mustBeConnectedIt is always
true.Rename
repositoryAccessMode.disableMaintenancetoallowMaintenance.This explicitly conveys when maintenance is allowed to run. This is related to accessing a repository in 'read-only' mode.