build(cli): set build info version and info when not set #4498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets `repo.BuildInfo` and `repo.BuildVersion` when they are not specified via link flags. The behavior for binaries built via CI and Make remains the same.
julio-lopez
commented
Apr 12, 2025
Comment on lines
+13
to
+14
| BuildInfo = "" | ||
| BuildVersion = "" |
Collaborator
Author
There was a problem hiding this comment.
Now empty by default, that was not the case before.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4498 +/- ##
==========================================
+ Coverage 75.86% 76.33% +0.47%
==========================================
Files 470 528 +58
Lines 37301 40050 +2749
==========================================
+ Hits 28299 30574 +2275
- Misses 7071 7466 +395
- Partials 1931 2010 +79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@jkowalski FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
repo.BuildInfoandrepo.BuildVersionwhen they are not specified via link flags.The behavior for binaries built via CI and Make remains the same.