refactor(cli): misc cleanups in internal/diff #4484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
julio-lopez
commented
Apr 2, 2025
- remove spurious log message, duplicates what is being sent to the output;
- nit: update struct comment;
- consolidate code via a parameterized function;
- rename variable for clarity, it makes it easier to understand by avoiding negative condition check;
- remove unused return value;
- replace if blocks with switch.
Duplicates what is being sent to the output
Makes it easier to understand by avoiding negative condition check. Also, removes unused return value
Collaborator
Author
|
@Rohit-BM18 PTAL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4484 +/- ##
==========================================
+ Coverage 75.86% 76.33% +0.46%
==========================================
Files 470 527 +57
Lines 37301 40000 +2699
==========================================
+ Hits 28299 30533 +2234
- Misses 7071 7459 +388
- Partials 1931 2008 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Looks good to me, thanks for refactoring the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.