Skip to content

Conversation

@julio-lopez
Copy link
Collaborator

@julio-lopez julio-lopez commented Apr 1, 2025

Extends error message with a generic, OS-independent hint about what the source of the error may be and a potential solution.

Also, modifies error message to avoid duplicate messages.

Extends error message with a generic, OS-independent hint about
what the source of the error may be and a potential solution.
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.32%. Comparing base (cb455c6) to head (ff53e1c).
Report is 455 commits behind head on master.

Files with missing lines Patch % Lines
cli/password.go 0.00% 1 Missing ⚠️
...nternal/passwordpersist/passwordpersist_keyring.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4480      +/-   ##
==========================================
+ Coverage   75.86%   76.32%   +0.46%     
==========================================
  Files         470      527      +57     
  Lines       37301    40030    +2729     
==========================================
+ Hits        28299    30554    +2255     
- Misses       7071     7463     +392     
- Partials     1931     2013      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-lopez julio-lopez marked this pull request as ready for review April 1, 2025 04:09
@julio-lopez julio-lopez changed the title chore(cli): add details to persisten password error message chore(cli): add details to persistent password error message Apr 1, 2025
@julio-lopez julio-lopez merged commit ad33441 into kopia:master Apr 1, 2025
32 of 34 checks passed
@julio-lopez julio-lopez deleted the nit/repo-password branch April 1, 2025 04:10
mpryc pushed a commit to mpryc/kopia that referenced this pull request May 8, 2025
)

Extends error message with a generic, OS-independent hint about
what the source of the error may be and a potential solution.

Also, modifies error message to avoid duplicate messages.

- kopia#4449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant