refactor(snapshots): refactored uploader into separate package #4450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c38474b to
1bd8e3f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4450 +/- ##
==========================================
+ Coverage 75.86% 76.35% +0.48%
==========================================
Files 470 527 +57
Lines 37301 40030 +2729
==========================================
+ Hits 28299 30563 +2264
- Misses 7071 7460 +389
- Partials 1931 2007 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Shrekster
approved these changes
Mar 14, 2025
Collaborator
|
Nice changes, and thanks for removing the Upload* prefixes fro function names! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is completely mechanical, but updated some type names to avoid stuttering.
upload.UploadCounters=>upload.Countersupload.UploadProgress=>upload.Progress