Skip to content

Conversation

@julio-lopez
Copy link
Collaborator

Avoid starting a maintenance task on the server when the repository connection (configuration) is read-only.

Avoid starting a maintenance task on the server when
the repository connection (configuration) is read-only.

Ref:
- kopia#4373
The name reflects that the function may not start a maintenance task manager.
@julio-lopez julio-lopez changed the title No maint read only fix(server): no maintenance server task on read-only repos Feb 13, 2025
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.33%. Comparing base (cb455c6) to head (48f062c).
Report is 418 commits behind head on master.

Files with missing lines Patch % Lines
internal/server/server_maintenance.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4408      +/-   ##
==========================================
+ Coverage   75.86%   76.33%   +0.47%     
==========================================
  Files         470      527      +57     
  Lines       37301    39935    +2634     
==========================================
+ Hits        28299    30486    +2187     
- Misses       7071     7441     +370     
- Partials     1931     2008      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julio-lopez julio-lopez marked this pull request as ready for review February 13, 2025 05:36
@julio-lopez julio-lopez enabled auto-merge (squash) February 13, 2025 05:37
@julio-lopez julio-lopez changed the title fix(server): no maintenance server task on read-only repos fix(server): prevent maintenance task on read-only repos Feb 13, 2025
@julio-lopez julio-lopez disabled auto-merge February 14, 2025 01:36
@julio-lopez julio-lopez enabled auto-merge (squash) February 14, 2025 01:37
@julio-lopez julio-lopez disabled auto-merge February 14, 2025 04:11
@julio-lopez julio-lopez merged commit 3fbe0bd into kopia:master Feb 14, 2025
27 checks passed
@julio-lopez julio-lopez deleted the no-maint-read-only branch February 14, 2025 04:13
Copy link
Contributor

@redgoat650 redgoat650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kopia attempts to run maintenance jobs on read-only repository connection

2 participants