fix(server): ensure server uploads "repodiag" blobs #4358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kopia server was not uploading any logs to the repository, because _"repodiag"_ blob uploads would always fail. The cause was the following: When the (log) repodiag blob PUT operation was initiated, the `Context` used for this operation was already canceled. The context used for blob uploads is passed to `repodiag.NewLogManager` when opening the repository. In the case of the kopia server, the repository is asynchronously opened in `server.Server.InitReposotoryAsync`. The context passed to `repo.Open` is canceled after the "open repository" server task completes. This issue was introduced in kopia#1691 Change: Use `context.WithoutCancel()` instead of the context passed when the repo diagnoser is created. New tests are included to reproduce this failure and verify the fix.
adcbfde to
954dee4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4358 +/- ##
==========================================
+ Coverage 75.86% 76.30% +0.43%
==========================================
Files 470 527 +57
Lines 37301 39920 +2619
==========================================
+ Hits 28299 30460 +2161
- Misses 7071 7451 +380
- Partials 1931 2009 +78 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
FYI @jkowalski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kopia server was not uploading any logs to the repository, because "repodiag" blob uploads would always fail.
The cause was the following: When the (log) repodiag blob PUT operation was initiated, the
Contextused for this operation was already canceled.The context used for blob uploads is passed to
repodiag.NewLogManagerwhen opening the repository. In the case of the kopia server, the repository is asynchronously opened inserver.Server.InitReposotoryAsync. The context passed torepo.Openis canceled after the "open repository" server task completes. This issue was introduced in #1691Change:
Use
context.WithoutCancel()instead of the context passed when the repo "diagnoser" is created.New tests are included to reproduce this failure and verify the fix.
Ref:
Thanks to: