Skip to content

feat(general): misc notifications improvements #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkowalski merged 4 commits into from
Dec 29, 2024
Merged

feat(general): misc notifications improvements #4319

jkowalski merged 4 commits into from
Dec 29, 2024

Conversation

@jkowalski
Copy link
Contributor

@jkowalski jkowalski commented Dec 29, 2024 •
edited
Loading

  • added API to test notification profiles
  • added --http-header to webhook notification configuration
  • refactored configuration to always apply defaults before persisting options in the repository
  • added 'notification profile show --profile-name=X' command
  • simplified internal notification API

@codecov
Copy link

codecov bot commented Dec 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.54248% with 16 lines in your changes missing coverage. Please review.

Project coverage is 76.11%. Comparing base (cb455c6) to head (c68f3bc).
Report is 377 commits behind head on master.

Files with missing lines Patch % Lines
cli/command_notification_profile_list.go 72.72% 3 Missing and 3 partials ⚠️
cli/command_notification_configure_common.go 72.72% 1 Missing and 2 partials ⚠️
cli/command_notification_configure_webhook.go 81.25% 2 Missing and 1 partial ⚠️
...ification/sender/webhook/webhook_sender_options.go 57.14% 2 Missing and 1 partial ⚠️
notification/notifyprofile/notification_profile.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4319      +/-   ##
==========================================
+ Coverage   75.86%   76.11%   +0.24%     
==========================================
  Files         470      526      +56     
  Lines       37301    39834    +2533     
==========================================
+ Hits        28299    30318    +2019     
- Misses       7071     7499     +428     
- Partials     1931     2017      +86

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkowalski
feat(general): various notifications improvements
26a4db3 
* added API to test notification profiles
* added --http-header to webhook notification configuration
* refactored configuration to always apply defaults before persisting options in the repository
* added 'notification profile show --profile-name=X' command
@jkowalski jkowalski force-pushed the notification-improvements branch from 97c1f89 to 26a4db3 Compare December 29, 2024 05:14
@jkowalski jkowalski force-pushed the notification-improvements branch 2 times, most recently from c3f2d29 to 5e07931 Compare December 29, 2024 08:08
@jkowalski jkowalski force-pushed the notification-improvements branch from 5e07931 to de3bbca Compare December 29, 2024 17:15
@jkowalski jkowalski changed the title feat(general): various notifications improvements feat(general): misc notifications improvements Dec 29, 2024
@jkowalski jkowalski merged commit c1757a0 into kopia:master Dec 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jkowalski