fix(server): handle unset password hash version in user profile #4259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec48ef7 to
baf96fd
Compare
When the password hashing version is not set, then the default one is used, so verifying the password works.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4259 +/- ##
==========================================
+ Coverage 75.86% 75.97% +0.11%
==========================================
Files 470 507 +37
Lines 37301 38913 +1612
==========================================
+ Hits 28299 29566 +1267
- Misses 7071 7380 +309
- Partials 1931 1967 +36 ☔ View full report in Codecov by Sentry. |
jkowalski
approved these changes
Nov 18, 2024
jkowalski
reviewed
Nov 18, 2024
| t.Errorf("invalid authenticator result for %v/%v: %v, want %v", username, password, got, want) | ||
| } | ||
| got := a.IsValid(ctx, r, username, password) | ||
| assert.Equal(t, want, got, "invalid authenticator result for %v/%v", username, password) |
Collaborator
Author
There was a problem hiding this comment.
No, assert makes sense here so other test cases are checked as well.
There is no reason to stop the test when this check fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes