refactor(general): avoid using empty master keys #3835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
reviewed
May 1, 2024
Collaborator
julio-lopez
left a comment
There was a problem hiding this comment.
couple of minor nits, LG otherwise
Collaborator
|
@bathina2 PTAL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3835 +/- ##
==========================================
+ Coverage 75.86% 77.03% +1.16%
==========================================
Files 470 479 +9
Lines 37301 28713 -8588
==========================================
- Hits 28299 22119 -6180
+ Misses 7071 4697 -2374
+ Partials 1931 1897 -34 ☔ View full report in Codecov by Sentry. |
julio-lopez
reviewed
May 1, 2024
Comment on lines
7
to
8
| "github.com/kopia/kopia/internal/crypto" | ||
| "github.com/stretchr/testify/require" |
Collaborator
There was a problem hiding this comment.
this is going to fail linting.
julio-lopez
reviewed
May 1, 2024
julio-lopez
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, empty master keys were passed to the underlying cryptographic primitives (HKDF, AEAD, etc.).
While this worked because the authentication mechanisms returned an error, it's best to avoid passing empty master keys to these primitives in the first place. This refactor avoids passing empty master keys and enforces this via an assertion in the key derivation function.