chore(ci): speed up tests that use polling with long intervals #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on speeding up tests that use long interval polling by replacing waiting with manual triggering of interval callbacks.
- Replace long timeouts using waitFor with manual triggering helpers.
- Introduce interval spies (setInterval/clearInterval) and corresponding trigger functions in multiple test files.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/pages/Tasks.test.jsx | Introduces interval mocking and triggerIntervals helper to speed up polling tests. |
| tests/components/SnapshotEstimation.test.jsx | Implements interval mocking and adds a helper to trigger intervals after component load. |
| tests/components/Logs.test.jsx | Applies interval mocking to control polling, replacing timed waits with manual triggering. |
tests/pages/Tasks.test.jsx
Outdated
| intervalCallbacks = []; | ||
| intervalId = 0; | ||
|
|
||
| intervalSpy = vi.spyOn(window, "setInterval").mockImplementation((callback, delay) => { |
There was a problem hiding this comment.
[nitpick] The interval mocking logic is duplicated; consider extracting it into a shared helper to reduce code duplication across tests.
Comment on lines
66
to
95
| let intervalSpy; | ||
| let clearIntervalSpy; | ||
| let intervalCallbacks = []; | ||
| let intervalId = 0; | ||
|
|
||
| beforeEach(() => { | ||
| serverMock = setupAPIMock(); | ||
| resetRouterMocks(); | ||
| vi.clearAllMocks(); | ||
|
|
||
| // Mock setInterval and clearInterval to control timing | ||
| intervalCallbacks = []; | ||
| intervalId = 0; | ||
|
|
||
| intervalSpy = vi.spyOn(window, "setInterval").mockImplementation((callback, delay) => { | ||
| const id = ++intervalId; | ||
| intervalCallbacks.push({ id, callback, delay }); | ||
| return id; | ||
| }); | ||
|
|
||
| clearIntervalSpy = vi.spyOn(window, "clearInterval").mockImplementation((id) => { | ||
| intervalCallbacks = intervalCallbacks.filter((item) => item.id !== id); | ||
| }); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| serverMock.reset(); | ||
| intervalSpy.mockRestore(); | ||
| clearIntervalSpy.mockRestore(); | ||
| intervalCallbacks = []; |
There was a problem hiding this comment.
[nitpick] Consider refactoring the repeated interval mocking setup into a common utility to enhance maintainability across tests.
Suggested change
| let intervalSpy; | |
| let clearIntervalSpy; | |
| let intervalCallbacks = []; | |
| let intervalId = 0; | |
| beforeEach(() => { | |
| serverMock = setupAPIMock(); | |
| resetRouterMocks(); | |
| vi.clearAllMocks(); | |
| // Mock setInterval and clearInterval to control timing | |
| intervalCallbacks = []; | |
| intervalId = 0; | |
| intervalSpy = vi.spyOn(window, "setInterval").mockImplementation((callback, delay) => { | |
| const id = ++intervalId; | |
| intervalCallbacks.push({ id, callback, delay }); | |
| return id; | |
| }); | |
| clearIntervalSpy = vi.spyOn(window, "clearInterval").mockImplementation((id) => { | |
| intervalCallbacks = intervalCallbacks.filter((item) => item.id !== id); | |
| }); | |
| }); | |
| afterEach(() => { | |
| serverMock.reset(); | |
| intervalSpy.mockRestore(); | |
| clearIntervalSpy.mockRestore(); | |
| intervalCallbacks = []; | |
| let intervalMock; | |
| beforeEach(() => { | |
| serverMock = setupAPIMock(); | |
| resetRouterMocks(); | |
| vi.clearAllMocks(); | |
| // Initialize interval mocking utility | |
| intervalMock = mockInterval(); | |
| }); | |
| afterEach(() => { | |
| serverMock.reset(); | |
| intervalMock.restore(); |
tests/components/Logs.test.jsx
Outdated
| intervalCallbacks = []; | ||
| intervalId = 0; | ||
|
|
||
| intervalSpy = vi.spyOn(window, "setInterval").mockImplementation((callback, delay) => { |
There was a problem hiding this comment.
[nitpick] The repeated interval mocking pattern here could be extracted into a shared helper to reduce duplication and simplify future maintenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.