refactor(ui): moved policy utils to a separate module #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors UI utilities by extracting policy-related helpers into a dedicated policyutil module and updating all imports and tests accordingly.
- Extract policy functions (
isAbsolutePath,checkPolicyPath,sourceQueryStringParams,PolicyTypeName,policyEditorURL,PolicyEditorLink) fromuiutilintopolicyutil - Update source imports in pages and components to reference
policyutil - Migrate and reorganize tests: remove policy tests from
uiutiltests, add tests inpolicyutil, and introduce a standalone component test forPolicyEditorLink
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/utils/uiutil.test.js | Removed policy-related tests from uiutil |
| tests/utils/uiutil-components.test.jsx | Updated to only test sizeWithFailures; removed policy tests |
| tests/utils/policyutil.test.js | Added comprehensive tests for new policyutil functions |
| tests/components/PolicyEditorLink.test.jsx | Added component tests for PolicyEditorLink |
| src/utils/uiutil.jsx | Removed policy utils and Link import |
| src/utils/policyutil.jsx | New module exporting extracted policy helper functions |
| src/pages/Snapshots.jsx | Updated imports: split uiutil and policyutil |
| src/pages/SnapshotHistory.jsx | Changed sourceQueryStringParams import to policyutil |
| src/pages/Policy.jsx | Updated PolicyTypeName import to policyutil |
| src/pages/Policies.jsx | Updated checkPolicyPath & policyEditorURL imports to policyutil |
| src/components/policy-editor/PolicyEditor.jsx | Updated imports: pull policy helpers from policyutil and component |
Comments suppressed due to low confidence (2)
tests/utils/uiutil-components.test.jsx:4
- The import
resetRouterMocksis no longer used in this test file. Consider removing it to keep imports clean.
import { resetRouterMocks } from "../react-router-mock.jsx";
tests/utils/uiutil-components.test.jsx:9
- [nitpick] This
vi.mocksetup appears to mock routing but the file only testssizeWithFailures. You may remove the router mock block to simplify the test.
vi.mock("react-router-dom", async () => {
| return "Directory: " + s.userName + "@" + s.host + ":" + s.path; | ||
| } | ||
|
|
||
| export function sourceQueryStringParams(src) { |
There was a problem hiding this comment.
[nitpick] Consider handling undefined or null source properties so the query string doesn’t contain literal undefined or null, e.g. defaulting to an empty string or omitting parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.