Skip to content

Conversation

@fabriciojs
Copy link
Member

Issue -
🧰 Improvement Yes
🏆 Feature Yes
🐛 Bug fix Yes
📝 Refactor Yes
⚠️ Break Change Yes

Description

Kool Cloud integration updates - leverage API for building deploy images locally if necessary.

Includes BUGFIX for signal proxying to child processes/parent process handling.


Notes

@fabriciojs fabriciojs requested a review from dbpolito December 26, 2023 17:38
@github-actions github-actions bot added release-drafter:added Release drafter: Added release-drafter:changed Release drafter: Changed release-drafter:major Release drafter: Major release-drafter:minor Release drafter: Minor labels Dec 26, 2023
@codecov
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 180 lines in your changes are missing coverage. Please review.

Comparison is base (df31408) 73.07% compared to head (bc85378) 70.46%.
Report is 7 commits behind head on main.

Files Patch % Lines
commands/cloud_deploy.go 40.84% 39 Missing and 3 partials ⚠️
services/cloud/api/endpoint.go 0.00% 39 Missing and 2 partials ⚠️
commands/cloud.go 31.42% 23 Missing and 1 partial ⚠️
commands/cloud_setup.go 0.00% 21 Missing ⚠️
services/cloud/api/deploy_create.go 0.00% 11 Missing ⚠️
services/cloud/api/deploy_start.go 0.00% 11 Missing ⚠️
services/cloud/api/deploy_destroy.go 0.00% 10 Missing ⚠️
services/cloud/api/deploy_exec.go 0.00% 10 Missing ⚠️
services/cloud/api/deploy_status.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   73.07%   70.46%   -2.61%     
==========================================
  Files          75       76       +1     
  Lines        3005     3024      +19     
==========================================
- Hits         2196     2131      -65     
- Misses        738      829      +91     
+ Partials       71       64       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriciojs fabriciojs merged commit 768eef9 into main Jan 5, 2024
@fabriciojs fabriciojs deleted the tweaks-cloud-setup branch January 5, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-drafter:added Release drafter: Added release-drafter:changed Release drafter: Changed release-drafter:major Release drafter: Major release-drafter:minor Release drafter: Minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants