Skip to content

kool status improvement #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabriciojs merged 3 commits into from
Oct 29, 2023
Merged

kool status improvement #480

fabriciojs merged 3 commits into from
Oct 29, 2023

Conversation

@fabriciojs
Copy link
Member

@fabriciojs fabriciojs commented Oct 28, 2023

Issue -
🪲 Bug Fix Yes
🧰 Improvement Yes
⚠️ Break Change No

Description

  • List all services even if no containers were created - read straight from config instead of containers list.

@fabriciojs fabriciojs requested a review from dbpolito October 28, 2023 17:11
@github-actions github-actions bot added release-drafter:changed Release drafter: Changed release-drafter:fixed Release drafter: Fixed release-drafter:minor Release drafter: Minor release-drafter:patch Release drafter: Patch labels Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fb1048) 73.42% compared to head (42fc0db) 73.50%.

❗ Current head 42fc0db differs from pull request most recent head d6430dd. Consider uploading reports for the commit d6430dd to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   73.42%   73.50%   +0.08%     
==========================================
  Files          75       75              
  Lines        2961     2963       +2     
==========================================
+ Hits         2174     2178       +4     
+ Misses        719      716       -3     
- Partials       68       69       +1
Files Coverage Δ
commands/status.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriciojs fabriciojs merged commit a0a5b5b into main Oct 29, 2023
@fabriciojs fabriciojs deleted the kool-status-tweaks branch October 29, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbpolito dbpolito Awaiting requested review from dbpolito

Assignees

No one assigned

Labels

release-drafter:changed Release drafter: Changed release-drafter:fixed Release drafter: Fixed release-drafter:minor Release drafter: Minor release-drafter:patch Release drafter: Patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabriciojs