Skip to content

Improved preset names + other tweaks #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabriciojs merged 3 commits into from
Oct 29, 2023
Merged

Improved preset names + other tweaks #479

fabriciojs merged 3 commits into from
Oct 29, 2023

Conversation

@fabriciojs
Copy link
Member

@fabriciojs fabriciojs commented Oct 28, 2023

Issue -
🧰 Improvement Yes
🏆 Feature Yes
⚠️ Break Change No

Description

  • Improve presets with better names
  • Merge TS/Typescript tags
  • Remove bad cloud setup default env

@github-actions github-actions bot added release-drafter:added Release drafter: Added release-drafter:changed Release drafter: Changed release-drafter:minor Release drafter: Minor labels Oct 28, 2023
@fabriciojs fabriciojs requested a review from dbpolito October 28, 2023 02:07
@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited
Loading

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (8fb1048) 73.42% compared to head (0396fd6) 73.19%.

❗ Current head 0396fd6 differs from pull request most recent head df2f0c3. Consider uploading reports for the commit df2f0c3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   73.42%   73.19%   -0.23%     
==========================================
  Files          75       75              
  Lines        2961     2970       +9     
==========================================
  Hits         2174     2174              
- Misses        719      727       +8     
- Partials       68       69       +1
Files Coverage Δ
core/presets/fake_parser.go 96.00% <100.00%> (ø)
commands/cloud_setup.go 9.23% <0.00%> (+0.13%) ⬆️
core/presets/parser.go 44.95% <60.00%> (-0.85%) ⬇️
commands/preset.go 46.42% <8.33%> (-8.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriciojs fabriciojs merged commit 852c3f0 into main Oct 29, 2023
@fabriciojs fabriciojs deleted the tweaks branch October 29, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbpolito dbpolito Awaiting requested review from dbpolito

Assignees

No one assigned

Labels

release-drafter:added Release drafter: Added release-drafter:changed Release drafter: Changed release-drafter:minor Release drafter: Minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabriciojs