Skip to content

Conversation

@fabriciojs
Copy link
Member

Issue -
🪲 Bug Fix No
🧰 Improvement Yes
🏆 Feature Yes
📖 Documentation No
⚠️ Break Change No

Description

Improvements to kool cloud setup and deploy error display.

@github-actions github-actions bot added release-drafter:added Release drafter: Added release-drafter:changed Release drafter: Changed release-drafter:minor Release drafter: Minor labels Sep 18, 2023
@fabriciojs fabriciojs added the release-drafter:changed Release drafter: Changed label Sep 18, 2023
@fabriciojs fabriciojs requested a review from dbpolito September 18, 2023 12:13
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 6.38% and project coverage change: -0.95% ⚠️

Comparison is base (8d6091e) 74.36% compared to head (86fc185) 73.42%.

❗ Current head 86fc185 differs from pull request most recent head c965494. Consider uploading reports for the commit c965494 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   74.36%   73.42%   -0.95%     
==========================================
  Files          75       75              
  Lines        2926     2961      +35     
==========================================
- Hits         2176     2174       -2     
- Misses        682      719      +37     
  Partials       68       68              
Files Changed Coverage Δ
commands/cloud_setup.go 9.09% <0.00%> (-2.80%) ⬇️
core/shell/shell.go 78.51% <0.00%> (-1.49%) ⬇️
services/cloud/api/deploy.go 71.08% <42.85%> (-3.60%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriciojs fabriciojs merged commit 1a18981 into main Oct 22, 2023
@fabriciojs fabriciojs deleted the cloud-improvements branch October 22, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-drafter:added Release drafter: Added release-drafter:changed Release drafter: Changed release-drafter:minor Release drafter: Minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants