Fix problems with callbacks and killINotify#22
Merged
kolmodin merged 3 commits intohaskell-fswatch:masterfrom Dec 3, 2016
Merged
Fix problems with callbacks and killINotify#22kolmodin merged 3 commits intohaskell-fswatch:masterfrom
kolmodin merged 3 commits intohaskell-fswatch:masterfrom
Conversation
1. We shouldn't run the callback inside mask_, because that prevents it from receiving StackOverflow, amongst other things. I think this was a n attempt to prevent the delivery of ThreadKilled inside the callback, but to do that you would need uninterruptibleMask_ 2. killThread doesn't wait for the threads to die, so use the async package and cancel/wait instead. 3. If the killThread happens during a callback, we don't want to discard the exception, because that will leave the thread running. I've added a new test for the problem of a callback hanging.
b7c6f6f to
2a29d8e
Compare
Collaborator
|
Thanks, I'll release a new version with these changes. On |
Contributor
Author
|
Thanks @kolmodin! I worked off the released version because I needed to deploy this locally, but releasing a new version would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't run the callback inside mask_, because that prevents it
from receiving StackOverflow, amongst other things. I think this was
a n attempt to prevent the delivery of ThreadKilled inside the
callback, but to do that you would need uninterruptibleMask_
killThread doesn't wait for the threads to die, so use the async
package and cancel/wait instead.
If the killThread happens during a callback, we don't want to discard
the exception, because that will leave the thread running.
I've added a new test for the problem of a callback hanging.