fix(links): preserve relative URLs in link editor (#359)

kolkov · kolkov · commit c691d3000abc · 2025-11-22T22:43:13.000+03:00
Use getAttribute('href') instead of .href property to preserve relative URLs when editing existing links. The .href property returns absolute URL with hostname, while getAttribute preserves the original relative path. Also removed debug console.log statement from focus() method (#324). Fixes #359 Fixes #324
diff --git a/projects/angular-editor/src/lib/ae-toolbar/ae-toolbar.component.ts b/projects/angular-editor/src/lib/ae-toolbar/ae-toolbar.component.ts
@@ -260,8 +260,10 @@ export class AeToolbarComponent {
     const selection = this.editorService.savedSelection;
     if (selection && selection.commonAncestorContainer.parentElement.nodeName === 'A') {
       const parent = selection.commonAncestorContainer.parentElement as HTMLAnchorElement;
-      if (parent.href !== '') {
-        url = parent.href;
+      // Use getAttribute to preserve relative URLs instead of href which returns absolute URL
+      const href = parent.getAttribute('href');
+      if (href !== '' && href !== null) {
+        url = href;
       }
     }
     url = prompt('Insert URL link', url);
@@ -380,6 +382,5 @@ export class AeToolbarComponent {
 
   focus() {
     this.execute.emit('focus');
-    console.log('focused');
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -260,8 +260,10 @@ export class AeToolbarComponent {`
`260`	`260`	`const selection = this.editorService.savedSelection;`
`261`	`261`	`if (selection && selection.commonAncestorContainer.parentElement.nodeName === 'A') {`
`262`	`262`	`const parent = selection.commonAncestorContainer.parentElement as HTMLAnchorElement;`
`263`		`- if (parent.href !== '') {`
`264`		`- url = parent.href;`
	`263`	`+ // Use getAttribute to preserve relative URLs instead of href which returns absolute URL`
	`264`	`+ const href = parent.getAttribute('href');`
	`265`	`+ if (href !== '' && href !== null) {`
	`266`	`+ url = href;`
`265`	`267`	`}`
`266`	`268`	`}`
`267`	`269`	`url = prompt('Insert URL link', url);`
`@@ -380,6 +382,5 @@ export class AeToolbarComponent {`
`380`	`382`
`381`	`383`	`focus() {`
`382`	`384`	`this.execute.emit('focus');`
`383`		`- console.log('focused');`
`384`	`385`	`}`
`385`	`386`	`}`