Improve desktop site user agent handling#82
Merged
Conversation
Owner
|
Sorry for the late review! 🙏 Thank you for the wonderful pull request! ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves Request desktop site handling in the WebView browser.
Previously, desktop mode changed the legacy
User-Agentstring and viewport settings, but some modern sites still detected the browser as mobile through Chromium User-Agent Client Hints. This could make desktop mode work on sites like Google and YouTube, while still failing on stricter sites.What Changed
UserAgentMetadatasupport for Chromium client hints.sec-ch-ua-platform: "Windows"sec-ch-ua-mobile: ?0100%initial scale, while mobile mode keeps the existing density-based scale.Why
Some sites no longer rely only on
navigator.userAgent. They also inspect User-Agent Client Hints likesec-ch-ua-mobileandsec-ch-ua-platform.Without matching those hints, WebView can send a desktop UA string while still exposing mobile-like metadata, causing certain sites to keep serving the mobile layout.