Skip to content

use objectMapperForSerialization for kotlin type classes#996

Merged
kobylynskyi merged 3 commits into
kobylynskyi:developfrom
jay3047:useObjectMapper-KOLTIN
Sep 5, 2022
Merged

use objectMapperForSerialization for kotlin type classes#996
kobylynskyi merged 3 commits into
kobylynskyi:developfrom
jay3047:useObjectMapper-KOLTIN

Conversation

@jay3047

@jay3047 jay3047 commented Sep 4, 2022

Copy link
Copy Markdown
Contributor

Description

Related to #995


Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

@jxnu-liguobin jxnu-liguobin self-requested a review September 5, 2022 06:30
@jay3047 jay3047 changed the base branch from master to develop September 5, 2022 07:07
@jay3047

jay3047 commented Sep 5, 2022

Copy link
Copy Markdown
Contributor Author

Not sure why sonar is failing , @jxnu-liguobin can you please help.

I think forked repo by default doesn't copy develop branch and we tend to create working branch from master which doesn't have develop under .git/refs/head

@jxnu-liguobin

Copy link
Copy Markdown
Collaborator

sonar

Usually we do not need to care about soar.

@jay3047

jay3047 commented Sep 5, 2022

Copy link
Copy Markdown
Contributor Author

sonar

Usually we do not need to care about soar.

Okay , in that case can you please review and merge if changes looks ok.

@jay3047

jay3047 commented Sep 5, 2022

Copy link
Copy Markdown
Contributor Author

@kobylynskyi Can you please review and merge

@jxnu-liguobin

Copy link
Copy Markdown
Collaborator

@kobylynskyi Can you please review and merge

He's probably still sleeping 😄 .

@kobylynskyi kobylynskyi merged commit 6dc3cf2 into kobylynskyi:develop Sep 5, 2022
@kobylynskyi kobylynskyi mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants