Parameterized field getters in type interface are missing parameters #859#913
Merged
Merged
Conversation
Owner
Author
|
Hi @jxnu-liguobin could you please have a look if same changes should be done in scala/kotlin .ftl files? Thank you! |
93d0813 to
78eb8d2
Compare
78eb8d2 to
8d2ffe4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Collaborator
Yes, it need do some work, but since kotlin and scala have treated the type interface as a field, this is a big change to scala and kotlin and must be changed to Now trait ProfileOwner {
val anyPinnableItems: Boolean
val email: String
}Chage to trait ProfileOwner {
def anyPinnableItems(a: Int): Boolean
def email(a: Int): String
}So, we can create a new issue and follow the problem until there is enough value to do. (using method is not friendly in most cases) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Related to #859
Changes were made to: