Skip to content

Fix #1429: Support custom type default values for enum#1458

Merged
kobylynskyi merged 1 commit into
kobylynskyi:mainfrom
rwo-trackunit:custom-enum-default-value
Feb 24, 2024
Merged

Fix #1429: Support custom type default values for enum#1458
kobylynskyi merged 1 commit into
kobylynskyi:mainfrom
rwo-trackunit:custom-enum-default-value

Conversation

@rwo-trackunit

Copy link
Copy Markdown
Contributor

Description

Related to #1429
Support default value for custom types mapped Enums.

Given
direction: OrderDirection = ASC
and
<OrderDirection>foo.bar.OrderDirection</OrderDirection>

Before
private foo.bar.OrderDirection direction = OrderDirection.ASC;
After:
private foo.bar.OrderDirection direction = foo.bar.OrderDirection.ASC;


Couldn't sleep, so thought I'd made myself useful.


Changes were made to:

  • Codegen library

@rwo-trackunit rwo-trackunit marked this pull request as ready for review February 10, 2024 21:56
@kobylynskyi

Copy link
Copy Markdown
Owner

@rwo-trackunit thanks for the contribution! Will include in the upcoming release.

@kobylynskyi kobylynskyi merged commit 6b41b5b into kobylynskyi:main Feb 24, 2024
@kobylynskyi kobylynskyi added this to the 5.10.0 milestone Feb 24, 2024
@kobylynskyi kobylynskyi added the enhancement New feature or request label Feb 24, 2024
@kobylynskyi

Copy link
Copy Markdown
Owner

This was released in 5.10.0

@rwo-trackunit rwo-trackunit deleted the custom-enum-default-value branch February 24, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants