Added an option to render Kotlin functions with suspend modifier#1377
Merged
Conversation
Collaborator
|
It looks good, looking forward to you completing it. By the way. SBT cannot compile kotlin by default unless using third-party plugins. So you don't need to consider SBT. And I am considering removing the code related to kotlin from the sbt plugin in this library. |
Contributor
Author
thanks! Yeah I didn't touch the SBT module |
jxnu-liguobin
approved these changes
Nov 6, 2023
kobylynskyi
approved these changes
Nov 9, 2023
Owner
|
Looks good! Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a configuration option for Kotlin generator to render functions with
suspendmodifier:when disabled:
when enabled:
I know this could be solved by providing a custom Freemarker template to the config, but it seems like supporting Kotlin coroutines is something one would expect to get out of the box.
Changes were made to: