Skip to content

Do not skip "...on" in all$ methods for union and interface projections#1376

Merged
kobylynskyi merged 4 commits into
kobylynskyi:mainfrom
trilogy-group:bugfix/fix-all-generation-for-unions
Nov 9, 2023
Merged

Do not skip "...on" in all$ methods for union and interface projections#1376
kobylynskyi merged 4 commits into
kobylynskyi:mainfrom
trilogy-group:bugfix/fix-all-generation-for-unions

Conversation

@sdaurea

@sdaurea sdaurea commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

Description

Related to #1375


Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

@jxnu-liguobin

jxnu-liguobin commented Nov 6, 2023

Copy link
Copy Markdown
Collaborator

When you open it, does it mean you are in need of it? This is great. Can you test if it really meets the requirements? (Test its results at runtime ) Thank you!

Because I skipped it directly to avoid testing the union.

@alaa-nassef

Copy link
Copy Markdown

When you open it, does it mean you are in need of it? This is great. Can you test if it really meets the requirements? (Test its results at runtime ) Thank you!

Because I skipped it directly to avoid testing the union.

@jxnu-liguobin to answer your first question, yes, we do need this in the project we're working on and it is currently kind of a blocker for us. As for testing results at runtime, we were planning to do this, but we have to publish our own version first and use it instead, which would need some more time

@kobylynskyi kobylynskyi added this to the 5.9.0 milestone Nov 9, 2023
@kobylynskyi kobylynskyi merged commit 797558d into kobylynskyi:main Nov 9, 2023
@kobylynskyi

Copy link
Copy Markdown
Owner

@alaa-nassef looks good!. Thanks for the contribution!

@derwild

derwild commented Nov 16, 2023

Copy link
Copy Markdown

I'm not sure about your release schedule, but can you already say, when the 5.9.0 maven plugin will be released?

@kobylynskyi

Copy link
Copy Markdown
Owner

@derwild targeting this week.

@derwild

derwild commented Nov 16, 2023

Copy link
Copy Markdown

@kobylynskyi nice, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"...on" is skipped in all$ methods for union and interface projections

5 participants