Skip to content

Made possible to use custom templates#1048

Merged
kobylynskyi merged 10 commits into
kobylynskyi:developfrom
velo:master
Mar 19, 2023
Merged

Made possible to use custom templates#1048
kobylynskyi merged 10 commits into
kobylynskyi:developfrom
velo:master

Conversation

@velo

@velo velo commented Mar 17, 2023 •
edited by kobylynskyi
Loading

Copy link
Copy Markdown
Contributor

Description

Added the configuration for manually selecting templates. This would allow anyone that needs/wants to modify a output, to do it by themselves.

For instance, I'm would like to use java record with lombok annotations, by using a custom template I can do it.

Related to #146 and potentially many others

Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

If the change seems reasonable, I will make the gradle plugin and SBT changes

@kobylynskyi kobylynskyi changed the base branch from master to develop March 18, 2023 01:21
@kobylynskyi

kobylynskyi commented Mar 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Owner

Hey @velo
Thanks for the contribution!
I like this feature.
Please address the comments I put in individual files.
Also here are additional notes:
1 - Please fix the build, for some reason maven codegen fails with NPE: https://github.com/kobylynskyi/graphql-java-codegen/actions/runs/4445081094/jobs/7821033595?pr=1048
2 - If you can append a new record to the end of the configs description table in codegen-options.md.
3 - If you are familiar with Gradle/SBT plugins, please add support to those too.
4 - Please also fix checkstyle warnings

Thank you!

kobylynskyi
kobylynskyi requested changes Mar 18, 2023
View reviewed changes
Comment thread src/main/java/com/kobylynskyi/graphql/codegen/generators/FreeMarkerTemplateFilesCreator.java Outdated
Comment thread src/main/java/com/kobylynskyi/graphql/codegen/model/MappingConfig.java Outdated
Comment thread src/main/java/com/kobylynskyi/graphql/codegen/model/MappingConfig.java Outdated
Comment thread src/test/java/com/kobylynskyi/graphql/codegen/GraphQLCodegenAnnotationsTest.java Outdated
Comment thread src/main/java/com/kobylynskyi/graphql/codegen/model/MappingConfig.java Outdated
@kobylynskyi kobylynskyi added this to the 5.7.0 milestone Mar 18, 2023
@kobylynskyi kobylynskyi mentioned this pull request Mar 18, 2023
Closed
Marvin Froeder and others added 3 commits March 20, 2023 08:55
kobylynskyi
kobylynskyi previously approved these changes Mar 19, 2023
View reviewed changes
@velo

velo commented Mar 19, 2023

Copy link
Copy Markdown
Contributor Author

Fixed scalafmt

@kobylynskyi kobylynskyi merged commit 0b212e6 into kobylynskyi:develop Mar 19, 2023
@kobylynskyi kobylynskyi mentioned this pull request Mar 19, 2023
Merged
@velo

velo commented Mar 20, 2023

Copy link
Copy Markdown
Contributor Author

Found a small buh on this, hope I can patch for the release

@velo velo mentioned this pull request Mar 20, 2023
Merged
6 tasks
@kobylynskyi kobylynskyi mentioned this pull request Mar 23, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kobylynskyi kobylynskyi kobylynskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@velo @kobylynskyi