Skip to content

chore: bump dep, path-to-regexp#188

Closed
iambumblehead wants to merge 1 commit into
koajs:masterfrom
iambumblehead:bump-dep-path-to-regexp
Closed

chore: bump dep, path-to-regexp#188
iambumblehead wants to merge 1 commit into
koajs:masterfrom
iambumblehead:bump-dep-path-to-regexp

Conversation

@iambumblehead

@iambumblehead iambumblehead commented Sep 12, 2024

Copy link
Copy Markdown

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

In response to #186, this attempts to update path-to-regexp from version 6 to version 8. This PR is incomplete (a few difficulties were encountered) and the original issue seems to have been resolved.

Submitting this PR just in case it may happen to be useful to anyone for any reason at all.

I don't know how to describe optional end-slash in paths used with path-to-regexp@8.1.0 and would request advice there if trying to complete this PR. Numerous experiments failed.

Thank you! :) Feel free to close or ignore this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants