Skip to content

chore: adds initial readablestream/response test [1882]#1884

Closed
yowainwright wants to merge 1 commit intomasterfrom
ISSUE-1882
Closed

chore: adds initial readablestream/response test [1882]#1884
yowainwright wants to merge 1 commit intomasterfrom
ISSUE-1882

Conversation

@yowainwright
Copy link
Member

@yowainwright yowainwright commented Jun 4, 2025 •
edited
Loading

Adds tests for WHATWG Response and ReadableStream objects:

  • ensures body data was properly transmitted.
  • ensures that ctx.body is preserved in the context even when empty status codes are set.

TODO

  • ensure test cases are valid
  • ensure unit test captures fix
  • ensure unneeded hacks are removed
  • check update with explicit fetch, and node-fetch

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (1ddb048) to head (e799ed5).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1884   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files           9        9           
  Lines        2064     2097   +33     
=======================================
+ Hits         2062     2095   +33     
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yowainwright yowainwright marked this pull request as ready for review June 4, 2025 04:25
@jonathanong
Copy link
Member

jonathanong commented Jun 5, 2025

let's test a fetch response. maybe we can also take a look into #1834

@yowainwright yowainwright marked this pull request as draft June 15, 2025 23:30
@yowainwright yowainwright force-pushed the ISSUE-1882 branch 5 times, most recently from 2fb8c8e to 28864a9 Compare July 13, 2025 04:42
@yowainwright yowainwright requested a review from jonathanong July 13, 2025 04:44
@yowainwright
Copy link
Member Author

yowainwright commented Jul 13, 2025

@jonathanong I updated and addressed fetch response. I can move onto #1834 next.

@yowainwright yowainwright marked this pull request as ready for review July 13, 2025 04:53
@yowainwright yowainwright force-pushed the ISSUE-1882 branch 2 times, most recently from cdd5b64 to befc142 Compare August 18, 2025 08:10
@yowainwright yowainwright requested a review from fengmk2 August 23, 2025 04:06
@yowainwright yowainwright mentioned this pull request Aug 23, 2025
Merged
6 tasks
@yowainwright yowainwright deleted the ISSUE-1882 branch October 20, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanong jonathanong Awaiting requested review from jonathanong

@fengmk2 fengmk2 Awaiting requested review from fengmk2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feat] improved tests for WHATWG Response and ReadableStream by checking the response body

2 participants

@yowainwright @jonathanong