breaking: remove special ENOENT support#1861
Merged
Conversation
fengmk2
approved these changes
Mar 19, 2025
|
Does https://github.com/koajs/send need to be updated with the new logic? |
I don't know why the middleware is not working for me however hard I try(I noticed there is a syntax error, nevertheless), I read through the source code and implemented an alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a huge breaking change as it breaks
fs.createReadStreamsupport. Instead, you'll have to make sure you'll handle the stream's errors before it reaches the koa response logic. This is good as you'd want to do this for all streams anyways. You can have an upstream middleware like:closes #1420