Closed
Conversation
683f127 to
1fc1825
Compare
Member
|
why not use is-stream directly? because it is in es6? |
Contributor
Author
I wasn't sure it is acceptable to introduce additional dependencies. |
Member
|
an external dependency is preferred if maintained from a reliable author, I can try to look later |
Contributor
|
@jonathanong I reviewed the library in question. Considering we're planning to move into the TS world, while I don't tend to prefer libraries that use |
Member
|
that's a good point, thanks! cc @kevinpeno |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are situations when we need to send response stream that is not an instance of node
Readablestream and current way of checking for streamvalue instanceof Streamfails.e.g. when using alternative module like readable-stream or some other cases
My usecase
Solution
Readablestream implementation.Tested also with this code