Added exports.default to package.json#1630
Merged
jonathanong merged 1 commit intokoajs:masterfrom Oct 20, 2024
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1630 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 5 5
Lines 507 507
Branches 142 142
=======================================
Hits 505 505
Misses 2 2 Continue to review full report at Codecov.
|
jeremy-daley-kr
approved these changes
Feb 2, 2022
3imed-jaberi
approved these changes
Apr 2, 2022
|
@3imed-jaberi Who has the ability to merge this? |
e5617c1 to
bddafea
Compare
bddafea to
2e38a4a
Compare
Contributor
|
@jonathanong should be gtg now, if its something we want merged. |
jonathanong
approved these changes
Oct 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per NodeJS documentation on the
package.jsonexportsobject, there seems to be a need for a fallbackdefaultkey:https://nodejs.org/api/packages.html#conditional-exports
Additionally, I'm seeing things like eslint fail to resolve until a
defaultkey has been specified. I've not dug any further into why, but I think some default should be defined until more options should later be added.