fix missing cleanup, if response socket is no longer writeable (issue 1547)#1593
fix missing cleanup, if response socket is no longer writeable (issue 1547)#1593titanism merged 3 commits intokoajs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1593 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 5 5
Lines 507 507
Branches 142 142
=======================================
Hits 505 505
Misses 2 2
Continue to review full report at Codecov.
|
miwnwski
left a comment
There was a problem hiding this comment.
LGTM, though would you mind adding a test for this?
|
I don't really know how to write tests for koa, so not sure if I can be of help with that. |
|
v2.16.0 released to npm with the backported fix https://github.com/koajs/koa/releases/tag/2.16.0 We needed this for our work on @forwardemail (since we use HTTP2 server) |
Relates to issue #1547, see my comment there