fix: Do not response Content-Length if Transfer-Encoding is defined#1562
Closed
charlyzeng wants to merge 2 commits intokoajs:masterfrom
Closed
fix: Do not response Content-Length if Transfer-Encoding is defined#1562charlyzeng wants to merge 2 commits intokoajs:masterfrom
charlyzeng wants to merge 2 commits intokoajs:masterfrom
Conversation
|
Hi @dead-horse , Why the latest version 2.13.3 does not contain these code? |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Nodejs http module can not handle response that contains both Content-Length and Transfer-Encoding header, you can see it at https://github.com/nodejs/node/blob/v16.6.1/deps/llhttp/src/llhttp.c#L5811.
Problem
Koa will auto set Content-Length response header when use
ctx.body = ..., but if Transfer-Encoding response header is defined, Content-Length should not be set. Otherwise, the response can not be handled by nodejs http module.How To Appear
As above, run

node server.jsto start server, then runnode client.jsto send a request. Finally, you'll get an error as follow:How To Resolve
Don't set Content-Length header if Transfer-Encoding is defined.