koa works strange with node-argon2 #670
Description
Hi!
Probably it's not the right place to report my problem, but I think it should be written down here too (also I will report it at node-argon2).
I tried to use argon2 in my koa application but I couldn't make it work because if I use node-argon2's hash method within a koa controller I get a strange timeout. I couldn't find out why this happens hence the question. I've created some dead simple examples to show the issue.
'use strict';
const koa = require('koa');
const app = module.exports = koa();
const argon2 = require('argon2');
function argon() {
return argon2.generateSalt().then(salt => {
console.log('SALT: ', salt);
return argon2.hash('some@test.com', salt).then(hash => {
console.log('HASH: ', hash);
return argon2.verify(hash, 'some@test.com');
});
});
}
try {
app.use(function *(){
try {
console.time('koa');
yield argon();
console.log('Hash verified');
console.timeEnd('koa');
this.body = 'Hash verified';
}
catch (err) {
console.error(err);
}
});
if (!module.parent) app.listen(3000);
}
catch (err) {
console.error(err);
}
#########################
// curl -X GET localhost:3000
// Result:
SALT: <Buffer d7 e6 f8 84 6c f6 e5 9d 32 61 16 37 1d 88 07 10>
HASH: $argon2i$m=4096,t=3,p=1$1+b4hGz25Z0yYRY3HYgHEA$YSdD4Pw1EoLeGsfH5QrEB8OklnwlV/r2f
// curl -X GET localhost:3000
// Then I needed to call the service again to get these messages:
Hash verified
koa: 322752.768ms
I tried to verify if this thing really only happens with koa so I modified the example two times
Example 1
Removed yield from the koa controller and used "plain" promises to create the hash, meaning I won't return a promise from the function call
'use strict';
const koa = require('koa');
const app = module.exports = koa();
const argon2 = require('argon2');
function argon() {
argon2.generateSalt().then(salt => {
console.log('SALT: ', salt);
argon2.hash('some@test.com', salt).then(hash => {
console.log('HASH: ', hash);
argon2.verify(hash, 'some@test.com').then(() => {
console.timeEnd('koa');
console.log('Hash verified');
});
});
});
}
try {
app.use(function *(){
try {
console.time('koa');
argon();
this.body = 'Hash will be verified';
}
catch (err) {
console.error(err);
}
});
if (!module.parent) app.listen(3000);
}
catch (err) {
console.error(err);
}
#########################
// curl -X GET localhost:3000
// Result:
Hash will be verified
// Then need to call it again to get
koa: 130070.741ms
Hash verified
SALT: <Buffer 7b 23 99 9e 81 4f 5d 28 95 d8 fa d9 63 13 4e 69>
HASH: $argon2i$m=4096,t=3,p=1$eyOZnoFPXSiV2PrZYxNOaQ$vFW1wXytkmaDe8lqsVAXmevYpVIH2SBngwfPjSfFbxc
It seems that koa fails to call an additional .next() on the iterator?!
Example 2
koa omitted
'use strict';
const argon2 = require('argon2');
function* compute() {
try {
yield crypto();
console.log('Hash verified');
}
catch (err) {
console.error(err);
}
}
function crypto() {
return argon2.generateSalt().then(salt => {
console.log('SALT: ', salt);
return argon2.hash('some@test.com', salt).then(hash => {
console.log('HASH: ', hash);
return argon2.verify(hash, 'some@test.com');
});
});
}
for (let _it of compute());
##############
$ node argon.js
Hash verified
SALT: <Buffer 0b 23 2c 4f 43 d0 f0 b4 70 86 98 9b b2 c5 9a 0d>
HASH: $argon2i$m=4096,t=3,p=1$CyMsT0PQ8LRwhpibssWaDQ$ChdSIU7F1FQx1n7gvvoPxsXO+OVSCdqhTybh3ejV8uk
Any thoughts about this?
tags: koa, argon2, node, timeout, promise, yield