fix: Use attestation-name output#980
Merged
imjasonh merged 1 commit intoko-build:mainfrom Mar 13, 2023
Merged
Conversation
Fixes ko-build#978 Uses the `attestation-name` output from `generator_generic_slsa3.yml` to get the artifact name to download. Also removes the `compile-generator` input as slsa-framework/slsa-github-generator#1163 was fixed. Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #980 +/- ##
=======================================
Coverage 52.50% 52.50%
=======================================
Files 43 43
Lines 3331 3331
=======================================
Hits 1749 1749
Misses 1353 1353
Partials 229 229 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
developer-guy
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #978
Uses the
attestation-nameoutput fromgenerator_generic_slsa3.ymlto get the artifact name to download.Also removes the
compile-generatorinput as slsa-framework/slsa-github-generator#1163 was fixed.