Skip to content

add slsa verifier installer action#969

Closed
mchmarny wants to merge 6 commits intoko-build:mainfrom
mchmarny:mchmarny-slsa-verfier-action
Closed

add slsa verifier installer action#969
mchmarny wants to merge 6 commits intoko-build:mainfrom
mchmarny:mchmarny-slsa-verfier-action

Conversation

@mchmarny
Copy link
Copy Markdown
Contributor

@mchmarny mchmarny commented Mar 3, 2023

Replaces manual SLSA verifier download with the installer action

slsa-framework/slsa-verifier/actions/installer@v2.0.1

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #969 (beb31c3) into main (5499f6f) will increase coverage by 0.32%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
+ Coverage   52.50%   52.82%   +0.32%     
==========================================
  Files          43       43              
  Lines        3331     3360      +29     
==========================================
+ Hits         1749     1775      +26     
- Misses       1353     1359       +6     
+ Partials      229      226       -3     

see 7 files with indirect coverage changes

developer-guy
developer-guy previously approved these changes Mar 3, 2023
Copy link
Copy Markdown
Collaborator

@developer-guy developer-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

updates slsa verifier parameters
needs: [goreleaser, provenance]
runs-on: ubuntu-latest
env:
ATT_FILE_NAME: "attestation.intoto.jsonl"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this attestation.intoto or multiple?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if multiples are fully supported yet but it works for me with the latest version here. In that case, the attestation file generated by SLSA Generator using goreleaser was multiple.intoto.jsonl

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is the PR that fixes this problem: https://github.com/ko-build/ko/pull/983/files

you may rebase from main


runs-on: ubuntu-latest
env:
ATT_FILE_NAME: "attestation.intoto.jsonl"
Copy link
Copy Markdown
Collaborator

@developer-guy developer-guy Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this anymore, you can remove this since you have the PROVENANCE variable where you verify it.

imjasonh
imjasonh previously approved these changes Mar 20, 2023
developer-guy
developer-guy previously approved these changes Apr 5, 2023
@developer-guy
Copy link
Copy Markdown
Collaborator

can you bump the version of the slsa-verifier-installer to 2.3.0 @mchmarny?

@mchmarny mchmarny dismissed stale reviews from developer-guy and imjasonh via beb31c3 May 18, 2023 22:23
@mchmarny
Copy link
Copy Markdown
Contributor Author

Done, updated to v2.3.0

@github-actions
Copy link
Copy Markdown

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@developer-guy
Copy link
Copy Markdown
Collaborator

@imjasonh we can merge this one.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 6, 2023

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@mchmarny mchmarny closed this by deleting the head repository Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants